#3052 closed defect (duplicate)

Stop mutating tempfile.tempdir as a side-effect of creating a Node

Reported by: exarkun Owned by:
Priority: normal Milestone: undecided
Component: code Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

Node.init_tempdir sets tempfile.tempdir so that Twisted Web will write uploaded files to a node-specific directory.

tempfile.tempdir is global state and mutating it for a particular Node instance causes all kinds of problems (for example, it means you can't really have two Node instances in one process; it also wreaks havoc on the test suite).

Get a feature into Twisted so that Twisted Web doesn't rely on this global state for upload file location and then use that feature instead of mutating tempfile.tempdir.

Change History (4)

comment:2 Changed at 2019-07-22T19:55:39Z by exarkun

The Twisted ticket is resolved but the change is not yet in a release.

comment:3 Changed at 2020-01-09T18:24:44Z by exarkun

The Twisted change was included in the Twisted 19.10.0 release in Nov 2019

comment:4 Changed at 2020-01-16T20:55:59Z by exarkun

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of ticket:1549

Note: See TracTickets for help on using tickets.