Opened at 2011-09-28T17:15:37Z
Closed at 2021-05-19T15:58:50Z
#1549 closed defect (fixed)
use new feature of Twisted to pass tempdir explicitly to twisted.web.http
Reported by: | zooko | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | eventually |
Component: | code-network | Version: | 1.9.0a2 |
Keywords: | twisted cleanup tempfile review | Cc: | zooko |
Launchpad Bug: |
Description
We currently poke a new value into the Python Standard Library's tempfile module so that when twisted.web.http.Request uses the default value it uses the value we want. To close this ticket, wait until Twisted has a fix for Twisted ticket 5281 and then use that new interface instead of the current kludge.
Change History (8)
comment:1 Changed at 2011-09-28T19:55:55Z by davidsarah
- Keywords twisted cleanup tempfile added
- Milestone changed from undecided to eventually
comment:2 Changed at 2020-01-16T20:54:28Z by exarkun
comment:3 Changed at 2020-01-16T20:56:13Z by exarkun
The Twisted change was included in the Twisted 19.10.0 release in Nov 2019, fwiw.
comment:4 Changed at 2020-01-17T17:02:03Z by exarkun
ticket:2900 was a duplicate of this
comment:5 Changed at 2020-11-18T20:54:04Z by exarkun
Welp I forgot about this and filed another duplicate, https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3512.
But I'm actually fixing this now so maybe that'll be the last one.
comment:6 Changed at 2020-11-18T23:18:04Z by exarkun
- Keywords review added
comment:7 Changed at 2020-11-26T15:44:28Z by exarkun
Fixed in https://github.com/tahoe-lafs/tahoe-lafs/commit/152c04e48cc2cd4be2fac731fb14d5c6e348b71b but I made the automation close the duplicate, ticket:3512.
comment:8 Changed at 2021-05-19T15:58:50Z by exarkun
- Resolution set to fixed
- Status changed from new to closed
Seems like I meant to close this last November.
Great ticket zooko! I failed to find it before filing https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3052 and another upstream ticket https://twistedmatrix.com/trac/ticket/9655
Twisted:9655 is resolved so I'll close Twisted:5281 as a duplicate. ticket:3052 is still open so I'll resolve that as a duplicate of this.