Opened at 2018-04-03T16:56:12Z
Closed at 2018-04-04T11:32:50Z
#2915 closed defect (fixed)
test_more_hypothesis sometimes provokes a deadline warning from Hypothesis
Reported by: | exarkun | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | unknown | Version: | 1.12.1 |
Keywords: | Cc: | ||
Launchpad Bug: |
Description
Seen sometimes on the "deprecations" builder:
test_more_hypothesis ... [OK] hypothesis_temporary_module_ca8c04296f296227cee4b5d10f5c7da8403a9baa:244: HypothesisDeprecationWarning: Test took 224.22ms to run. In future the default deadline setting will be 200ms, which will make this an error. You can set deadline to an explicit value of e.g. 300 to turn tests slower than this into an error, or you can set it to None to disable this check entirely.
The test in question suppresses the "too slow" health check, mistakenly, in an attempt to quiet this. We need to change the deadline, not suppress "too_slow".
It's okay to just quiet this warning because CI uses shared hosts and we can't predict what CPU resources will be available during a test run.
We can quiet this warning across the whole code base by mimicking what's done here: https://github.com/LeastAuthority/txkube/pull/181
Change History (1)
comment:1 Changed at 2018-04-04T11:32:50Z by exarkun
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Fixed by https://github.com/tahoe-lafs/tahoe-lafs/pull/486