'IndexError: list index out of range' building zfec 1.4.19

[davidsarah]

See this failure on a Tahoe buildslave:
​http://tahoe-lafs.org/buildbot/builders/Randy%20FreeBSD-amd64/builds/331/steps/build/logs/stdio

It doesn't happen for zfec 1.4.17, so the only changeset that could be responsible is ​http://tahoe-lafs.org/trac/zfec/changeset/382/trunk/

[davidsarah]

Also see ​http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1365

[davidsarah]

This appears to be caused by the distribution of zfec 1.4.19 (e.g. ​http://pypi.python.org/packages/source/z/zfec/zfec-1.4.19.tar.gz#md5=b2624373e625d580777980766a65fa87 ) having no bundled zetuptoolz egg. That causes zfec's setup.py to fail at line 14.

[davidsarah]

Replying to davidsarah:

It doesn't happen for zfec 1.4.17, so the only changeset that could be responsible is ​http://tahoe-lafs.org/trac/zfec/changeset/382/trunk/

This was an incorrect conclusion, because the problem (at least the immediate one) is a packaging error not reflected in any changeset.

[zooko]

The proximate cause of this error is that I built the zfec-1.4.19 distribution without having setuptools_darcs installed. (Of course, if setuptools_darcs were auto-installed when building then this wouldn't have happened, and also if setuptools_darcs weren't needed at all then this wouldn't have happened either.)

I just installed setuptools_darcs, added a tag zfec-1.4.20 immediately following the current zfec-1.4.19, and built again and now it works.

[davidsarah]

Does zfec-1.4.19 need to be removed from PyPI, or will 1.4.20 always be used in preference? I suppose 1.4.19 might be used if the download of 1.4.20 fails.