Opened 16 years ago
Last modified 14 years ago
#1 new defect
it says "saving please wait...done" *after* it is finished saving
Reported by: | zooko | Owned by: | somebody |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | component1 | Version: | |
Keywords: | tiddly | Cc: |
Description
At least on Firefox-3, when you click "Save Changes" then nothing happens for a while, and then it says "saving...please wait" and "thign saved" all at once. It would be nicer if it would pop up "saving...please wait" *before* the nothing-happens-for-a-while part.
Change History (4)
comment:1 Changed 16 years ago by zooko
comment:2 Changed 15 years ago by zooko
Okay it is more complicated than I thought. When you click "save" it seems to do some network traffic, then pop up the "I'm finished saving!" announcement, then wait for a few seconds (while evaluating some Javascript?) then do a whole bunch more network traffic, and only then is it really saved so that other people can see it. This is very ugly -- it is easy for people (including me) to think that it is done long before it is actually done. If they close the window at that point then they'll probably lose their work. If the click "save" in another window at that point then they'll probably lose their work. In any case it is a pain-in-the-neck. Here is a listing of the "recent operations" from clicking save. Hey what the hell! Where is the upload? I do not know why there is not "upload" in there. :-( Is it a bug in Tahoe-LAFS's "current and recent operations" display?
10:31:49 17-Dec-2009 publish 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:49 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:49 17-Dec-2009 mapupdate MODE_WRITE 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:43 17-Dec-2009 publish 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:42 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:37 17-Dec-2009 mapupdate MODE_WRITE 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:13 17-Dec-2009 publish 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:13 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:11 17-Dec-2009 mapupdate MODE_WRITE 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:11 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:10 17-Dec-2009 mapupdate MODE_READ 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:10 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:10 17-Dec-2009 mapupdate MODE_READ 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:10 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:10 17-Dec-2009 mapupdate MODE_READ 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished 10:31:04 17-Dec-2009 download gaque632dhcngw2cdwipcyhepy No 758.0kB 100.0% Finished 10:31:04 17-Dec-2009 retrieve 6s64wyhfbm7yxb5cwzqblnndpe No 2.0kB 100.0% Finished 10:31:04 17-Dec-2009 mapupdate MODE_READ 6s64wyhfbm7yxb5cwzqblnndpe No -NA- 100.0% Finished
comment:3 Changed 14 years ago by zooko
comment:4 Changed 14 years ago by arch_o_median
- Keywords tiddly added
Wait a minute. Nowadays I can manually test this and see that it says "saving...please wait / RSS feed saved / Empty template saved / Main TiddlyWiki? file saved" *before* it has finished uploading (I can tell by looking at Tahoe node's "Recent Uploads and Downloads"). This is erring on the opposite side and this error is much worse, because if someone sees that it says "Done" and then goes and modifies the same wiki from a different web browser they can cause write collisions and all sorts of confusion. I'm pretty sure that this is what just broke my blog.
So the easiest way to fix this ticket is just to take out the "saving please wait..." entirely and make sure that the "saved" message doesn't appear until after the HTTP PUTs or POSTs have all *completed*. The best way to fix this ticket is then to add in "saving please wait..." which appears immediately, before any of those operations have been *started*.