#918 assigned defect

Abstraction violations in web/info.py

Reported by: davidsarah Owned by: davidsarah
Priority: minor Milestone: eventually
Component: code-frontend-web Version: 1.5.0
Keywords: cleanup Cc:
Launchpad Bug:

Description

At source:src/allmydata/web/info.py?rev=4164#L92 , we see

  if IDirectoryNode.providedBy(node):
      node = node._node

(and similarly in a few other methods of MoreInfo).

This is getting the underlying file node for a directory node, but it's doing it by getting the _node attribute, which follows the private instance variable convention. Probably there should be a method on IFilesystemNode to get the underlying file node (which would return self for non-directory nodes).

Change History (3)

comment:1 Changed at 2010-02-01T19:46:25Z by davidsarah

  • Milestone changed from undecided to 1.7.0

comment:2 Changed at 2010-03-12T04:17:34Z by davidsarah

  • Owner set to davidsarah
  • Status changed from new to assigned

comment:3 Changed at 2010-04-12T17:15:59Z by davidsarah

  • Milestone changed from 1.7.0 to eventually
Note: See TracTickets for help on using tickets.