Opened at 2010-01-14T04:29:50Z

Closed at 2010-01-14T22:34:14Z

#900 closed defect (fixed)

Fix 'local variable is assigned to but not used' warnings from pyflakes

Reported by: davidsarah Owned by: somebody
Priority: minor Milestone: 1.6.0
Component: code Version: 1.5.0
Keywords: Cc:
Launchpad Bug:

Description (last modified by warner)

The latest version of pyflakes (0.4.0) gives a bunch of warnings about local variables not being used. Fix them.

(the code was pyflakes-0.3.0 clean, but pyflakes-0.4.0 has new checks)

Change History (3)

comment:1 Changed at 2010-01-14T18:06:25Z by davidsarah

  • Priority changed from major to minor

Most of these warnings look harmless. I'm not sure about a few of them -- for example archives_dir starting at source:src/allmydata/scripts/tahoe_backup.py#L106​ .

comment:2 Changed at 2010-01-14T19:43:46Z by warner

  • Description modified (diff)

I think that archives_dir stuff is vestigal, from before backupdb started tracking directories (it used to have to find and read the most recent snapshot). It can be removed.

I'll make a pass through these at some point.

comment:3 Changed at 2010-01-14T22:34:14Z by warner

  • Milestone changed from undecided to 1.6.0
  • Resolution set to fixed
  • Status changed from new to closed

731d15e56f509f9a, e9223fcd0efd5a5c, and 2e098e2a4ddc66a8 fixes these.. the tree is now pyflakes-0.4.0-clean on my box.

Note: See TracTickets for help on using tickets.