Context Navigation

← Previous Ticket
Next Ticket →

Opened at 2010-01-07T15:42:09Z

Last modified at 2011-12-31T06:20:49Z

#884 assigned defect

give nice error page when URL is mangled or from the future

Reported by:	zooko	Owned by:	davidsarah
Priority:	major	Milestone:	soon
Component:	code-frontend-web	Version:	1.5.0
Keywords:	usability newurls forward-compatibility wui error	Cc:
Launchpad Bug:

Description

As reported by Jack Lloyd on tahoe-dev:

http://allmydata.org/pipermail/tahoe-dev/2010-January/003508.html

Change History (15)

comment:1 Changed at 2010-01-07T20:23:24Z by davidsarah

Keywords newurls added

If you like this bug, you might also like #885, which aims to automatically fix one of the most common forms of mangling.

comment:2 Changed at 2010-01-16T17:29:39Z by davidsarah

Keywords forward-compatibility added
Milestone changed from undecided to 1.6.0
Owner set to davidsarah
Summary changed from give nice error page when URL is mangled to give nice error page when URL is mangled or from the future

URLs from the future also give an ugly error message:

http://testgrid.allmydata.org:3567/uri/lafs:from_the_future

Fixing this ticket would help the PREFIXED_RO_URI proposal in #833:

http://testgrid.allmydata.org:3567/uri/imm.lafs:from_the_future

comment:3 Changed at 2010-01-26T16:56:04Z by zooko

Milestone changed from 1.6.0 to eventually

With the Tahoe-LAFS -r4170:

GET unknown URI type: can only do t=info and t=json, not t=.
Using a webapi server that supports a later version of Tahoe may help.

I guess it could be prettier, but this is an improvement. :-)

comment:4 Changed at 2010-02-01T19:41:24Z by davidsarah

Milestone changed from eventually to 1.7.0

comment:5 Changed at 2010-02-02T02:46:52Z by davidsarah

#274 was a duplicate. From the description and comments of that ticket:

[...] This case should present a friendly error message in the wui that says: "The requested link has an incorrect format. If you pasted this from the clipboard, make sure you copied the entire link without extra line breaks."

Also, the wapi should return an "invalid cap" error code, so that extensions can report to their own users the problem.

[...]

Bonus wishlist feature: Detect common cases, such as internal newlines or missing suffixes or prefixes and tell the user the specific problem.

(One such case is #885.)

For instance if there is no "URI:<type>:" string anywhere in the input, remind them that caps always include these strings. If there *is* such a substring, but the other fields are too short, suggest that they included whitespace (from "friendly" formatting) or chopped off the end.

comment:6 Changed at 2010-02-02T02:47:24Z by davidsarah

Keywords wui error added

comment:7 Changed at 2010-02-09T04:29:02Z by davidsarah

Also, if a path goes through an unknown node, the error is "Sorry, but I couldn't find the object you requested.", which is not as helpful as it could be:

http://testgrid.allmydata.org:3567/uri/URI:DIR2:bntvvn2bf37vwmrd3ttbygt4s4:qymwa2lcvhjvi3hnamxew6ywro5jmj7zfnspmrpqv3n7faibprlq/immutable-future-file/foo

It should say that a later Tahoe version is needed to read children of 'immutable-future-file'.