Opened at 2023-07-07T20:04:01Z

Closed at 2023-07-11T21:21:48Z

#4044 closed defect (fixed)

allmydata.test.web.test_webish.TahoeLAFSSiteTests.test_large_request fails sometimes

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description (last modified by exarkun)

This unit test relies on removing permissions from a directory to result in an error from the platform to tell it that the code under test is operating as expected. This comes with a multi-paragraph comment to explain the weirdness.

Also, since permissions don't work like this on Windows, there's a branch in the test for the runtime platform.

Then, even not on Windows, permissions don't work like this if the process has extra privileges, so the test fails sometimes.

Instead of all this, let's just change the interface of WebishServer? so it is easy to test.

Change History (2)

comment:1 Changed at 2023-07-07T20:07:57Z by exarkun

  • Description modified (diff)

comment:2 Changed at 2023-07-11T21:21:48Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In f354b3a/trunk:

Merge pull request #1312 from exarkun/4044.simpler-webish-test

Make a TahoeLAFSSite test simpler and more reliable

Fixes: ticket:4044

Note: See TracTickets for help on using tickets.