Opened at 2022-12-13T14:21:20Z

Closed at 2023-01-06T15:56:29Z

#3953 closed defect (fixed)

tox "typechecks" and "codechecks" are run in a lot of places but don't need to be

Reported by: exarkun Owned by:
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

The "codechecks" tox env should have the same output regardless of platform or Python version. There's no need to run it more than once per CI run.

The "typechecks" tox env could in principle have different outcomes, I guess, because some platform-specific packages might contribute to its result (or you could even have package X that has different versions for different platforms or Python versions). However, tahoe is mostly unannotated and I don't think we get any real value from running the type checker more than once.

The redundant runs are on Windows, which are already some of the slowest CI jobs, so removing them will shorten the overall time to complete one CI run too.

Change History (2)

comment:2 Changed at 2023-01-06T15:56:29Z by itamarst

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.