Opened at 2008-04-19T09:19:37Z
Closed at 2009-06-25T16:01:13Z
#388 closed defect (fixed)
Debian changelog is not up to date
Reported by: | esteve | Owned by: | esteve |
---|---|---|---|
Priority: | minor | Milestone: | eventually |
Component: | packaging | Version: | 1.0.0 |
Keywords: | debian, packaging | Cc: | |
Launchpad Bug: |
Description
The Debian changelog file (misc/$(TAHOE_ARCH)/debian/changelog) still reads "0.6.0-1plus", thus when a Debian package is built from the Tahoe source code, it is incorrectly named allmydata-tahoe_0.6.0-1plus_all.deb even though it was built from the 1.0.0 sources
Attachments (1)
Change History (6)
comment:1 Changed at 2008-04-21T02:14:04Z by zooko
Changed at 2008-04-22T16:26:35Z by esteve
comment:2 Changed at 2008-04-22T16:27:26Z by esteve
I've attached a patch that fixes this issue. It adds increment-deb-version to the deb-ARCH make target, it wasn't called and thus debian/changelog wasn't updated.
comment:3 Changed at 2008-08-19T18:13:35Z by zooko
- Owner changed from nobody to esteve
esteve: I'm sorry that I didn't notice this ticket and apply your patch already. However it looks like Brian has already fixed this a different way. If you agree that this is fixed, please close this ticket.
comment:4 Changed at 2009-03-08T22:02:11Z by warner
- Component changed from unknown to packaging
comment:5 Changed at 2009-06-25T16:01:13Z by zooko
- Keywords debian packaging added
- Resolution set to fixed
- Status changed from new to closed
I believe that this was long since fixed. Thanks, esteve and Brian.
Thanks for the bug report, esteve. I checked e.g. misc/feisty/debian/changelog and you are right. One thing I don't understand is why our buildbots which build Debian packages from the Tahoe source are coming up with the right version numbers.
Here is the timeline of those buildbots:
http://allmydata.org/buildbot/waterfall?show_events=false&branch=&builder=edgy&builder=feisty2.5&builder=etch&builder=gutsy&builder=deb-edgy&builder=deb-feisty&builder=deb-etch&builder=deb-gutsy&reload=none
And here is a recent invocation of make setup-deb ARCH=gutsy TAHOE_ARCH=feisty:
http://allmydata.org/buildbot/builders/deb-gutsy/builds/571/steps/debuild/logs/stdio
It looks like our Makefile is invoking debchange --newversion. Were you using the make setup-deb target of our Makefile, or using a debian tool directly?