Opened at 2021-05-21T15:00:27Z
#3719 new defect
tahoe_cp doesn't correctly determine when it needs to copy bytes
Reported by: | itamarst | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | unknown | Version: | n/a |
Keywords: | Cc: | ||
Launchpad Bug: |
Description
tahoe_cp appears to have optimizations to skip copying bytes in some cases.
However, it's buggy: it does if source.need_to_copy_bytes: (see implementation of Copier.need_to_copy_bytes) but need_to_copy_bytes is a method! So it always comes out True, instead of calling the method and seeing the response.
If that bug is fixed it hits some currently untested code paths and uncovers some bugs. So fixing this would also involve fixing those currently unreachable optimized code paths.
Note: See
TracTickets for help on using
tickets.