Opened at 2020-11-24T18:19:16Z

Closed at 2021-01-02T17:48:19Z

#3529 closed defect (fixed)

Stop using the mock library for testing: src/allmydata/test/test_connections.py

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: mock Cc:
Launchpad Bug:

Description (last modified by exarkun)

See ​​​​​​​​​​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3519

In a review on the test_nodes.py, adiroiban left some good feedback about the work necessary here: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/925/files/a97184868d1bb71e02f72f3c884882dc6f9c8166#diff-2474ff668b91234f2437ebd46396ef827282250d1e22e5104ee564892dc92223

Change History (3)

comment:1 Changed at 2020-11-24T18:19:41Z by exarkun

  • Summary changed from src/allmydata/test/test_connections.py to Stop using the mock library for testing: src/allmydata/test/test_connections.py

comment:2 Changed at 2020-12-15T18:21:34Z by exarkun

  • Description modified (diff)

comment:3 Changed at 2021-01-02T17:48:19Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 855521f/trunk:

Merge pull request #935 from LeastAuthority?/3529.test_connections-no-mock

Remove mock usage from test_connections.py

Fixes: ticket:3529

Note: See TracTickets for help on using tickets.