Opened at 2020-10-23T12:54:01Z

Closed at 2020-10-26T15:55:37Z

#3486 closed defect (fixed)

Delegate responsibility for figuring out local network configuration to `netifaces`

Reported by: exarkun Owned by: GitHub <noreply@…>
Priority: normal Milestone: undecided
Component: unknown Version: n/a
Keywords: review Cc:
Launchpad Bug:

Description

allmydata.util.iputil has a lot of code for trying to figure out what network addresses are locally assigned. This involves finding and running various child processes and scraping information from their output.

This code is somewhat complex and unnecessarily slow (due to launching new processes). It also fails if it cannot find any of these external helpers.

The well-established netifaces Python package provides the same functionality behind a much simpler interface.

Replace the current complex code with something simpler using netifaces.

Change History (2)

comment:1 Changed at 2020-10-23T13:34:05Z by exarkun

  • Keywords review added
  • Owner exarkun deleted

​https://github.com/tahoe-lafs/tahoe-lafs/pull/872

comment:2 Changed at 2020-10-26T15:55:37Z by GitHub <noreply@…>

  • Owner set to GitHub <noreply@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 25ee761/trunk:

Merge pull request #872 from tahoe-lafs/3486.netifaces

Switch to netifaces

Fixes: ticket:3486

Note: See TracTickets for help on using tickets.