Opened at 2020-10-16T15:24:18Z
Closed at 2020-10-20T16:32:40Z
#3481 closed defect (fixed)
The introducer fixture in the integration tests is generated with bogus configuration when local neither ip nor ifconfig are found in the usual locations
Reported by: | exarkun | Owned by: | GitHub <noreply@…> |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | unknown | Version: | n/a |
Keywords: | review | Cc: | |
Launchpad Bug: |
Description
_synchronously_find_addresses_via_config will return an empty list if it cannot find one of the tools it wants to use. It mostly looks at some hard-coded locations but it will try to search PATH for ifconfig. However, the integration tests launch the introducer process with PATH unset so this case never works.
https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3480 is about the problem in general. This ticket is about the mistake of leaving PATH unset for the child processes and then continuing to try to run the integration tests even if the introducer has an unusable configuration.
Change History (3)
comment:1 Changed at 2020-10-16T16:39:43Z by exarkun
- Keywords review added
comment:2 Changed at 2020-10-16T18:19:35Z by exarkun
comment:3 Changed at 2020-10-20T16:32:40Z by GitHub <noreply@…>
- Owner set to GitHub <noreply@…>
- Resolution set to fixed
- Status changed from new to closed
In 8adc8f2/trunk:
https://github.com/tahoe-lafs/tahoe-lafs/pull/866