Opened at 2020-04-09T18:58:40Z

Closed at 2020-04-27T14:12:33Z

#3294 closed defect (fixed)

port allmydata.web.root.IncidentReporter to use twisted.web.template

Reported by: sajith Owned by: sajith
Priority: normal Milestone: Support Python 3
Component: code-frontend Version: n/a
Keywords: python3 nevow Cc:
Launchpad Bug:

Description

Child of ##3244.

Change History (1)

comment:1 Changed at 2020-04-27T14:12:33Z by Sajith Sasidharan <sajith@…>

  • Resolution set to fixed
  • Status changed from new to closed

In a14cee5/trunk:

Remove nevow from allmydata.web.root.IncidentReporter?

This change calls for an explanation:

  • RenderMixin doesn't seem to be adding anything here, so it is

gone.

  • The web browser was unhappy without a charset in the response (Firefox 74 was anyway), so content-type header also gets a charset=UTF-8.
  • Returning a Unicode string made nevow appserver unhappy, so it is just a str. The precise error message was:

exceptions.TypeError?: ('Could not adapt', u'An incident report has been saved to logs/incidents/ in the node directory.', <InterfaceClass? nevow.inevow.IResource>)

Fixes: ticket:3294

Note: See TracTickets for help on using tickets.