Opened at 2019-11-19T17:20:16Z
Closed at 2019-11-26T14:27:35Z
#3265 closed enhancement (fixed)
Re-use/keep alive single storage plugin web resource
Reported by: | exarkun | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | code-frontend-web | Version: | n/a |
Keywords: | review-needed | Cc: | |
Launchpad Bug: |
Description
The storage plugin web feature currently asks the storage plugin for its web resource every single time. This generally means there is one web resource per web request. This means the web resource can't have any persistent state unless it finds somewhere else to keep it.
It would be more convenient if the web resource could have persistent state on itself which was guaranteed to live as long as the node itself lives (which is approximately as long as the Python process lives).
An alternative to this would be for the plugin itself to keep the web resource alive and return it for repeated calls to get_client_resource. This is problematic because the node's whole configuration is a parameter to this method. The plugin would need to implement caching which correctly respects the node configuration which is non-trivial.
Change History (2)
comment:1 Changed at 2019-11-19T18:00:09Z by exarkun
- Keywords review-needed added
comment:2 Changed at 2019-11-26T14:27:35Z by exarkun
- Resolution set to fixed
- Status changed from new to closed
https://github.com/tahoe-lafs/tahoe-lafs/pull/667