Opened at 2008-02-26T16:41:36Z

Last modified at 2010-05-30T21:35:26Z

#318 new defect

wapi: test that we return 200 or 201 as appropriate

Reported by: zooko Owned by:
Priority: major Milestone: soon
Component: code-frontend-web Version: 0.8.0
Keywords: standards test Cc:
Launchpad Bug:

Description

Per docs/webapi.txt, web servers ought to return 200 (OK) when modifying an existing file and 201 (Created) when creating a new file. Fix ours to do that.

Change History (10)

comment:1 Changed at 2008-02-26T16:41:50Z by zooko

  • Milestone changed from 0.8.0 (Allmydata 3.0 Beta) to undecided
  • Type changed from defect to enhancement
  • Version changed from 0.7.0 to 0.8.0

comment:2 Changed at 2008-02-26T16:41:59Z by zooko

  • Component changed from unknown to code-frontend-web
  • Owner nobody deleted

comment:3 Changed at 2008-02-26T16:42:45Z by zooko

webapi.txt said: " According to the

HTTP/1.1 specification (rfc2616), this should return a 200 (OK) code when modifying an existing file, and a 201 (Created) code when creating a new file. (TODO: as of 0.8, the web server only returns 200, never 201)."

comment:4 Changed at 2008-06-16T20:06:11Z by warner

I think this might be implemented now (source:src/allmydata/web/filenode.py#L49​), but we don't have test cases to prove it.

comment:5 Changed at 2008-06-16T20:06:58Z by warner

  • Milestone changed from eventually to 1.2.0

let's pull this into the 1.2.0 milestone (the current task is to add test coverage)

comment:6 Changed at 2009-06-30T17:51:14Z by zooko

  • Milestone changed from 1.5.0 to eventually

comment:7 Changed at 2010-01-07T00:54:45Z by davidsarah

  • Keywords standards test added

comment:8 Changed at 2010-02-27T08:39:25Z by davidsarah

  • Milestone changed from eventually to 1.7.0

comment:9 Changed at 2010-02-27T08:39:50Z by davidsarah

  • Summary changed from wapi: return 200 or 201 as appropriate to wapi: test that we return 200 or 201 as appropriate
  • Type changed from enhancement to defect

comment:10 Changed at 2010-05-30T21:35:26Z by zooko

  • Milestone changed from 1.7.0 to soon
Note: See TracTickets for help on using tickets.