#2971 closed defect (fixed)

FileShouldVanishException mis-uses super()

Reported by: exarkun Owned by: exarkun
Priority: normal Milestone: undecided
Component: unknown Version: 1.12.1
Keywords: magic-folder, test, dev-infrastructure Cc:
Launchpad Bug:

Description

class FileShouldVanishException(Exception):
    """                                                                                                                                                                                                                                                                                   
    A file or files we expected to disappear did not within the                                                                                                                                                                                                                           
    timeout                                                                                                                                                                                                                                                                               
    """
    def __init__(self, path, timeout):
        super(self, FileShouldVanishException).__init__(
            u"'{}' still exists after {}s".format(path, timeout),
        )

The super() call has its arguments reversed.

Change History (3)

comment:2 Changed at 2019-02-18T14:52:10Z by exarkun

  • Keywords review-needed removed
  • Owner set to exarkun

Self-reviewing and merging to unblock myself for further magic-folder improvements.

comment:3 Changed at 2019-02-18T14:53:08Z by GitHub <noreply@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 6f7e125/trunk:

Merge pull request #549 from tahoe-lafs/2971.super-argument-order

Fix super() argument order

Fixes: ticket:2971

Note: See TracTickets for help on using tickets.