--hide-ip should turn on connections tcp=tor

[warner]

While manually testing tor-based client setup, I hit an extra step that I thought could be removed. While we've defined the [node] reveal-IP-address = false setting to be purely a safety flag (the only thing it can do is hit the brakes on node startup), I think it might be ok to have the --hide-ip CLI argument be more active.

In particular, I think I'd like --hide-ip to cause *two* things to happen:

• set [node] reveal-IP-address = false
• add [connections] tcp = tor

The reasoning is that:

• with reveal=false, the default tcp = tcp will be rejected
• the only other legitimate value is tcp = tor (we might add tcp = none at some point, but that'll be strictly less functional than tor)

[dawuud]

made this change and added a test case; pull-request for your review here: ​https://github.com/tahoe-lafs/tahoe-lafs/pull/343

[Brian Warner <warner@…>]

In 3282f2a/trunk:

Merge PR 343 from david415/2820.hide_ip_set_tcp_tor.0

Closes ticket:2820