Opened at 2016-08-09T02:48:22Z
Closed at 2016-08-23T23:37:26Z
#2803 closed defect (wontfix)
Magic Folder logging
Reported by: | meejah | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | undecided |
Component: | unknown | Version: | 1.11.0 |
Keywords: | Cc: | ||
Launchpad Bug: |
Description
All of the magic-folder logging goes through QueueMixin._log which is a call-through to Node.log, which just calls-through to allmydata.util.log, which assigns msg as foolscap.logging.log which is really the .msg of a singleton FoolscapLogger instance.
...but, I can't see how they're ever emitted (e.g. there's no observers set up in foolscap's FoolscapLogger?).
Much of the logging should also be given a level=NOISY kwarg so that it only shows up during debug etc.
All that said, it would be nice to use the new Twisted structured-ish-logging APIs which has the benefit of delaying string-interpolation as long as possible (which may be "forever" for many cases). I don't know how or if that would affect logging from Foolscap pieces.
Change History (1)
comment:1 Changed at 2016-08-23T23:37:26Z by meejah
- Resolution set to wontfix
- Status changed from new to closed