Opened at 2016-07-22T05:10:11Z
Closed at 2016-08-25T06:30:00Z
#2801 closed defect (fixed)
connections.yaml support on trunk is incomplete
| Reported by: | warner | Owned by: | warner |
|---|---|---|---|
| Priority: | major | Milestone: | 1.12.0 |
| Component: | code-network | Version: | 1.11.0 |
| Keywords: | Cc: | daira, dawuud | |
| Launchpad Bug: |
Description
We're starting to land the support for multiple introducers and connection overrides, which is great. Last week a few patches from dawuud's pull-requests made it into trunk, but it seems like they're incomplete. e4d93a7, in particular, references a StorageBroker.got_static_announcement(), which doesn't exist. I think this function must have been added in a separate patch which didn't make it in. We don't have any tests which exercise this clause (I suspect the tests exist, but got lost in the merge as well).
This causes the node to crash if launched with a NODEDIR/private/connections.yaml present.
This ticket is to remind us to fix this before making a release.
Change History (5)
comment:1 Changed at 2016-08-02T14:57:42Z by dawuud
comment:2 Changed at 2016-08-22T12:30:46Z by dawuud
i added a basic unit test and i fixed many problems with the code i had submitted. ready to be reviewed.
comment:3 Changed at 2016-08-22T12:31:06Z by dawuud
- Owner set to warner
comment:4 Changed at 2016-08-25T06:29:50Z by dawuud
comment:5 Changed at 2016-08-25T06:30:00Z by dawuud
- Resolution set to fixed
- Status changed from new to closed
https://github.com/tahoe-lafs/tahoe-lafs/pull/302
here's some code... i didn't yet write tests.