#2779 new defect

add tests to catch things like tox.ini not being in MANIFEST.in

Reported by: warner Owned by:
Priority: major Milestone: soon
Component: packaging Version: 1.11.0
Keywords: Cc:
Launchpad Bug:

Description

I got an IRC report today that you can't run tox from an unpacked 1.11.0 source tarball, because I forgot to include tox.ini in the MANIFEST.in file (so it doesn't get copied into sdist tarballs). Oops.

The task is to make a buildbot test that (via a checked-in helper script) makes an sdist tarball, unpacks it into a new directory, then steps into that directory and runs 'tox' successfully.

It's probably ok if we don't run a full test suite, just enough to make sure the test files got copied in.

It might also be good to have a script that builds+unpacks an sdist, then compares the files in the original (git checkout) source tree against the unpacked ones, and fails if there are any unexpected differences.

Change History (5)

comment:1 Changed at 2016-04-13T07:03:27Z by Brian Warner <warner@…>

In 04f1a3c/trunk:

Merge branch 'pr259' from meejah:add-tox

refs ticket:2779

comment:2 Changed at 2016-04-13T22:21:14Z by warner

  • Summary changed from add tox.ini to MANIFEST.in to add tests to catch things like tox.ini not being in MANIFEST.in

comment:3 Changed at 2016-06-28T18:20:37Z by warner

  • Milestone changed from 1.12.0 to 1.13.0

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders

comment:4 Changed at 2020-06-30T14:45:13Z by exarkun

  • Milestone changed from 1.13.0 to 1.15.0

Moving open issues out of closed milestones.

comment:5 Changed at 2021-03-30T18:40:19Z by meejah

  • Milestone changed from 1.15.0 to soon

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.