Opened at 2015-12-04T01:42:33Z
Closed at 2016-10-18T22:14:29Z
#2597 closed defect (fixed)
Magic Folder: adapt smoke-test script to work on Windows
| Reported by: | daira | Owned by: | meejah |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.12.0 |
| Component: | code-frontend-magic-folder | Version: | n/a |
| Keywords: | test magic-folder windows | Cc: | |
| Launchpad Bug: |
Description
The current script assumes that tahoe start demonizes, which it doesn't on Windows (#27).
Change History (6)
comment:1 Changed at 2015-12-07T15:55:59Z by daira
- Owner changed from daira to meejah
comment:2 Changed at 2016-03-22T05:02:52Z by warner
- Milestone changed from 1.11.0 to 1.12.0
comment:3 Changed at 2016-09-05T22:01:16Z by meejah
I tried the new py.test based tests on a windows VM, and they don't "quite" run. The problem is the "restart Alice and Bob" piece. This is required by magic-folders (after the invite/join), but it's also somewhat "weird" that "tahoe start" on Windows does a very different thing than "tahoe start" on other platforms.
Although it would break the CLI "API", I think what would be ideal is to introduce a "tahoe run" command that does the same thing on both platforms (that is, runs in the foreground) and make "tahoe start" print an error-message and exit on windows (i.e. "please use 'tahoe run' instead"). Then, the tests can use "tahoe run" and can do their own thing to re-start. (Note: "tahoe stop" already fails to work on windows).
Additionally, perhaps we can remove the need to re-start the client nodes when a magic-folder is added?
comment:4 Changed at 2016-09-05T22:06:26Z by meejah
Oh, there's already a "tahoe run". The py.tests should use that, then :)
comment:5 Changed at 2016-10-11T16:22:11Z by meejah
I believe this can be closed. I will re-test to confirm.
comment:6 Changed at 2016-10-18T22:14:29Z by meejah
- Resolution set to fixed
- Status changed from new to closed
Yes, tests run on windows
Milestone renamed