Opened at 2015-11-02T14:43:36Z
Closed at 2015-12-14T22:56:42Z
#2563 closed defect (fixed)
Magic Folder: decide what the download scan delay should be
| Reported by: | daira | Owned by: | daira |
|---|---|---|---|
| Priority: | normal | Milestone: | undecided |
| Component: | code-frontend-magic-folder | Version: | 1.10.1 |
| Keywords: | magic-folder performance latency usability | Cc: | |
| Launchpad Bug: |
Description
It is currently 3 seconds, but that's probably too frequent.
Change History (6)
comment:1 Changed at 2015-12-07T21:35:53Z by dawuud
comment:2 follow-up: ↓ 5 Changed at 2015-12-07T21:44:06Z by dawuud
comment:3 Changed at 2015-12-09T11:16:25Z by dawuud
review needed
comment:4 Changed at 2015-12-14T22:10:03Z by daira
- Status changed from new to assigned
comment:5 in reply to: ↑ 2 Changed at 2015-12-14T22:19:12Z by daira
Replying to dawuud:
fixed here: https://github.com/tahoe-lafs/tahoe-lafs/pull/211
Merged in https://github.com/tahoe-lafs/tahoe-lafs/commit/b5cf81475f3f043bd76288070956a985963fd2c8.
comment:6 Changed at 2015-12-14T22:56:42Z by dawuud
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
I may have found a bug:
the Downloader sets self.turn_delay to 3 seconds... however that variable is used in two places;
this is wrong: https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.5/src/allmydata/frontends/magic_folder.py#L176
this is correct: https://github.com/tahoe-lafs/tahoe-lafs/blob/2438.magic-folder-stable.5/src/allmydata/frontends/magic_folder.py#L680