consistently use self.mktemp() to create a temporary directory in tests

[daira]

Currently we use a hotchpotch of methods to create a temporary directory for a test -- specifying the name manually, using a workdir method, using self.mktemp() from twisted.trial.unittest.TestCase, etc. (It is usually consistent within a test module but not across modules.)

We should just use self.mktemp(), or if there is something wrong with that then we should consistently use our own mixin.

[warner]

I agree it's a bit of a mess. My only two concerns:

• cleaning up the directory when we're done, so we don't litter /tmp/ (or wherever) with leftovers
• being able to find the leftover state when something goes wrong

Trial puts everything in ./_trial_temp, and rmtrees it at the beginning of each test run. This provides a predictable location, and an upper bound (of size=1) on the litter.

So I guess I'm in favor of using our own mixin that uses the (fully-qualified) name of the test case to produce a subdirectory of _trial_temp.

[daira]

Replying to warner:

So I guess I'm in favor of using our own mixin that uses the (fully-qualified) name of the test case to produce a subdirectory of _trial_temp.

mktemp() from twisted.trial.unittest.TestCase already does that.

[daira]

The one thing I don't like about mktemp() is that the path it generates is not deterministic, due to its use of mkdtemp (​implementation in Twisted v15.2.0). What I actually want is os.path.dirname(os.path.dirname(self.mktemp()), I think. Maybe it would be better to have a mixin to shorten that, so that if we want to change it, we only need to do so in one place.

[daira]

Also, I think I'd prefer for our mixin method to return an absolute Unicode path, rather than a relative str path.

[warner]

Milestone renamed

[warner]

moving most tickets from 1.12 to 1.13 so we can release 1.12 with magic-folders

[exarkun]

Probably switch to testtools and use the TempDir? fixture.

[exarkun]

Moving open issues out of closed milestones.

[meejah]

Ticket retargeted after milestone closed