Opened at 2014-08-19T17:37:49Z

Closed at 2014-09-05T05:07:19Z

Last modified at 2014-09-09T00:18:55Z

#2282 closed defect (fixed)

remove the feature of auto-installing stdeb

Reported by: daira Owned by: warner
Priority: normal Milestone: 1.10.1
Component: packaging Version: 1.10.0
Keywords: stdeb sdist debian setuptools setup_requires packaging Cc:
Launchpad Bug:

Description (last modified by daira)

There's a hack in setup.py​ to add stdeb >= 0.3 to the setup requirements automatically when the sdist_dsc command is used.

This is a bad idea because we want to avoid use of setup_requires, to mitigate #2286 (and also because pip doesn't check hashes specified in requirements.txt for setup_requires dependencies).

Change History (11)

comment:1 Changed at 2014-08-30T00:37:45Z by daira

  • Description modified (diff)

comment:2 Changed at 2014-09-02T16:59:12Z by warner

  • Owner set to warner

comment:3 Changed at 2014-09-02T18:18:23Z by warner

  • Status changed from new to assigned

I'll remove this.

comment:4 Changed at 2014-09-05T05:07:09Z by warner

  • Milestone changed from 1.11.0 to 1.12.0

comment:5 Changed at 2014-09-05T05:07:19Z by Brian Warner <warner@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In a1cc7df23d88a0ad92d83967da024f1f52950462/trunk:

remove obsolete debian-package building tools

setup.py: stop sometimes-depending upon 'stdeb'
setup.cfg: don't try to alias 'sdist_dsc'
misc/build_helpers/build-deb.py: delete this, it was really old anyways

Closes ticket:2282 (trac).

comment:6 Changed at 2014-09-07T18:14:33Z by daira

  • Milestone changed from 1.12.0 to 1.11.0

comment:7 Changed at 2014-09-08T15:31:53Z by Brian Warner <warner@…>

In a1cc7df23d88a0ad92d83967da024f1f52950462/trunk:

remove obsolete debian-package building tools

setup.py: stop sometimes-depending upon 'stdeb'
setup.cfg: don't try to alias 'sdist_dsc'
misc/build_helpers/build-deb.py: delete this, it was really old anyways

Closes ticket:2282 (trac).

comment:8 follow-up: Changed at 2014-09-08T21:27:34Z by daira

I'm concerned that the removal of the sdist_dsc = update_version sdist_dsc alias might result in broken packages, if the procedure used by packagers was relying on it.

comment:9 Changed at 2014-09-08T21:50:01Z by Brian Warner <warner@…>

In a1cc7df23d88a0ad92d83967da024f1f52950462/trunk:

remove obsolete debian-package building tools

setup.py: stop sometimes-depending upon 'stdeb'
setup.cfg: don't try to alias 'sdist_dsc'
misc/build_helpers/build-deb.py: delete this, it was really old anyways

Closes ticket:2282 (trac).

comment:10 in reply to: ↑ 8 Changed at 2014-09-08T22:15:46Z by warner

(meta: why the heck is trac re-posting my comment-message-triggered comments multiple times?)

Replying to daira:

I'm concerned that the removal of the sdist_dsc = update_version sdist_dsc alias might result in broken packages, if the procedure used by packagers was relying on it.

I checked the Ubuntu .deb packaging, and they don't use sdist_dsc. Same with debian/sid. They both use debhelper, which ultimately does setup.py install --force --root=XYZ --no-compile. I think any other debian-format packagers would follow their lead, and not use sdist_dsc either.

One of the many advantages of letting the professionals take over our home-brew debian packages :).

comment:11 Changed at 2014-09-09T00:18:55Z by daira

OK, that was the only concern I had. LGTM

Note: See TracTickets for help on using tickets.