logo.png is not found in allmydata-tahoe as installed via easy_install and pip

[joepie91]

I've attempted to install allmydata-tahoe through both easy_install and pip, and in both cases the logo in the interface top bar did not work. The logo file is present, but the HTTPd is somehow not finding it. The CSS works fine.

• Screenshot: ​http://owely.com/4mFMHU
• Error: ​http://owely.com/1wGbXa

File exists:

[sven ~/projects/cvm 00:16:32] ls -al /usr/lib/python2.7/site-packages/allmydata/web/static/icon.png
-rw-r--r-- 1 root root 467 May  9 15:35 /usr/lib/python2.7/site-packages/allmydata/web/static/icon.png

Installation log:

linux-fi74:/usr/lib/python2.7/site-packages # easy_install allmydata-tahoe
Searching for allmydata-tahoe
Reading http://pypi.python.org/simple/allmydata-tahoe/
Reading http://allmydata.org/
Reading https://tahoe-lafs.org/
Reading http://tahoe-lafs.org/
Best match: allmydata-tahoe 1.10.0
Downloading http://pypi.python.org/packages/source/a/allmydata-tahoe/allmydata-tahoe-1.10.0.tar.gz#md5=cbc2660b9aad2b2941da57445f5dc3f3
Processing allmydata-tahoe-1.10.0.tar.gz
Writing /tmp/easy_install-bAclt5/allmydata-tahoe-1.10.0/setup.cfg
Running allmydata-tahoe-1.10.0/setup.py -q bdist_egg --dist-dir /tmp/easy_install-bAclt5/allmydata-tahoe-1.10.0/egg-dist-tmp-MLh9MH
no version-control data found, leaving _version.py alone
package init file 'src/allmydata/web/static/__init__.py' not found (or not a regular file)
package init file 'src/allmydata/web/static/css/__init__.py' not found (or not a regular file)
warning: no previously-included files matching '*~' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
Adding allmydata-tahoe 1.10.0 to easy-install.pth file
Installing tahoe script to /usr/bin

Installed /usr/lib/python2.7/site-packages/allmydata_tahoe-1.10.0-py2.7.egg
Processing dependencies for allmydata-tahoe
Finished processing dependencies for allmydata-tahoe

The ~/.tahoe/logs/twistd.log file does not contain anything relevant to logo.png.

• Distro: openSUSE 12.3
• uname -a: Linux linux-fi74.site 3.7.10-1.1-desktop #1 SMP PREEMPT Thu Feb 28 15:06:29 UTC 2013 (82d3f21) x86_64 x86_64 x86_64 GNU/Linux
• Filesystem: ext4

[zooko]

According to ​http://owely.com/1wGbXa the browser is requesting "​http://localhost:3456/img/logo.png". Would that be satisfied by a file located in /usr/lib/python2.7/site-packages/allmydata/web/static/icon.png? Looking at src/allmydata/webish.py?annotate=blame&rev=c4d7b7b109b583b0c142bac9fae5d983f25fdd1c#L145​, it looks like the URL should be more like "​http://localhost:3456/static/logo.png" and the path in the filesystem would be...

src/allmydata/client.py?annotate=blame&rev=b989555d96e96b6f9b0664cf63afeafef4a8b83d#L445​ whatever is configured for your "staticdir" in your tahoe.cfg. Unless there's something else that I'm missing that processes URLs with "/img/" in them?

[joepie91]

This is the only relevant bit in my tahoe.cfg, and it's set to the default value:

web.port = tcp:3456:interface=127.0.0.1
web.static = public_html

I suppose that the <img> pointing at /img/ rather than /static/ might indeed be the issue.

[daira]

Oops, I see the problem. package_data in setup.py should include "allmydata.web.static.img": ["*.png"].

[Daira Hopwood <david-sarah@…>]

In 37c8b733a57dbbc4f9db0b3c8427f4e07994c3fa/trunk:

setup.py: add allmydata/web/static/img/*.png to package_data. refs #1969

Signed-off-by: Daira Hopwood <david-sarah@…>

[daira]

I reproduced this and verified it as fixed by the above patch. Thanks for the report!

[daira]

Zooko: the file is src/allmydata/web/static/img/logo.png​. (I misread "logo" as "icon" as well to start with.)

[zooko]

+1