Opened at 2013-04-24T13:58:07Z

Closed at 2013-05-01T21:39:53Z

#1953 closed defect (fixed)

include git branch name in the --version[-and-path] output

Reported by: daira Owned by: daira
Priority: normal Milestone: 1.10.1
Component: code Version: 1.10a2
Keywords: versioning appname reviewed Cc:
Launchpad Bug:

Description

The linear versioning of the Tahoe code makes it difficult to distinguish branches (such as the I2P branch or the cloud backend branch). In ticket:1939#comment:4 Zooko suggests to change the appname in the I2P branch, but that falls foul of #1159. It also depends on branch maintainers to remember to do the right thing, which is quite inconvenient given that the code needs to be patched to change the appname. If tahoe --version[-and-path] (and the version info on the Welcome page) showed the git branch name, that would be much better I think.

Change History (5)

comment:1 Changed at 2013-04-24T15:32:25Z by daira

  • Keywords review-needed added
  • Owner changed from daira to zooko

Please review: ​https://github.com/tahoe-lafs/tahoe-lafs/commit/1953-branch-in-version.

comment:2 Changed at 2013-04-24T22:07:53Z by zooko

  • Keywords reviewed added; review-needed removed

comment:3 Changed at 2013-04-24T22:08:57Z by zooko

  • Owner changed from zooko to daira

comment:4 Changed at 2013-04-24T22:46:51Z by warner

  • Milestone changed from soon to 1.11.0

I made one comment on that patch, but otherwise it seems good. I don't want to add it to 1.10, though, feels slightly risky this late in the process.

comment:5 Changed at 2013-05-01T21:39:53Z by Daira Hopwood <david-sarah@…>

  • Resolution set to fixed
  • Status changed from new to closed

In 8a1b2c7aa6f10882:

Show git branch in version output. fixes #1953
Also make sure strings in _version.py are correctly escaped, and repair a test.

Signed-off-by: Daira Hopwood <david-sarah@…>

Note: See TracTickets for help on using tickets.