#1945 closed defect (fixed)
WUI regression: Welcome page doesn't display on client-only nodes due to _node_key not being present.
| Reported by: | daira | Owned by: | warner |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.10.0 |
| Component: | code-frontend-web | Version: | 1.10a2 |
| Keywords: | wui regression blocker test-needed | Cc: | |
| Launchpad Bug: |
Description (last modified by daira)
See https://github.com/tahoe-lafs/tahoe-lafs/pull/40. However that seems like the wrong fix to me. Perhaps Client in src/allmydata/client.py should be calling self._maybe_create_node_key() unconditionally rather than only in init_storage(), so that all nodes have node keys?
Change History (9)
comment:1 Changed at 2013-04-17T01:00:25Z by daira
- Owner set to warner
comment:2 Changed at 2013-04-17T01:01:24Z by daira
- Keywords regression added
comment:3 Changed at 2013-04-17T01:02:04Z by daira
- Keywords test-needed added
comment:4 Changed at 2013-04-17T01:07:36Z by daira
- Version changed from 1.9.2 to 1.10a2
comment:5 Changed at 2013-04-17T01:17:22Z by warner
- Status changed from new to assigned
comment:6 Changed at 2013-04-17T01:47:25Z by daira
Also, we must not have had any test that depended on a node key being generated for a client-only node.
comment:7 Changed at 2013-04-18T07:07:27Z by Brian Warner <warner@…>
- Resolution set to fixed
- Status changed from assigned to closed
In b989555d96e96b6f:
comment:8 Changed at 2013-04-18T15:21:43Z by daira
Reviewed, +1.
comment:9 Changed at 2014-03-05T02:44:41Z by daira
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
Yeah, all sorts of client-ish nodes (client-only and client-plus-server) should have these "node keys". I'll create a new method init_nodekey() and have it called (before init_storage()) unconditionally.
Good catch Leif!