#1940 closed defect (invalid)

trac is rendering git diffs (in attachments) badly?

Reported by: warner Owned by:
Priority: normal Milestone: soon
Component: dev-infrastructure Version: n/a
Keywords: Cc:
Launchpad Bug:

Description

https://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/166/166-3.diff

I think it ought to be a regular "git diff" output, but trac is only showing the summary (counts of adds/deletes). This might be trac's diff renderer getting confused.

1	 src/allmydata/scripts/admin.py          |   19 +--
2	 src/allmydata/scripts/cli.py            |   92 ++++++------
3	 src/allmydata/scripts/common.py         |   48 +++----
4	 src/allmydata/scripts/create_node.py    |   16 +--
5	 src/allmydata/scripts/debug.py          |   47 ++++---
6	 src/allmydata/scripts/keygen.py         |   10 +-
7	 src/allmydata/scripts/runner.py         |   45 +++++-
8	 src/allmydata/scripts/startstop_node.py |   22 ++-
9	 src/allmydata/scripts/stats_gatherer.py |   10 +-
10	 src/allmydata/test/test_cli.py          |  235 ++++++++++++++++++-------------
11	 src/allmydata/test/test_deepcheck.py    |   28 ++--
12	 src/allmydata/test/test_runner.py       |    2 +-
13	 src/allmydata/test/test_system.py       |    6 +-
14	 13 files changed, 309 insertions(+), 271 deletions(-)

Change History (1)

comment:1 Changed at 2013-04-04T16:21:20Z by warner

  • Resolution set to invalid
  • Status changed from new to closed

Oh, nevermind, the attachment was truncated: I uploaded the wrong thing when I attached the diff. Trac is rendering the truncated data just fine.

Note: See TracTickets for help on using tickets.