Opened at 2012-09-17T15:38:01Z
Closed at 2014-12-11T22:29:11Z
#1808 closed defect (wontfix)
error message gets downloaded instead of rendered by Konqueror
Reported by: | zooko | Owned by: | zooko |
---|---|---|---|
Priority: | normal | Milestone: | soon |
Component: | code-frontend-web | Version: | 1.9.2 |
Keywords: | error konqueror wui html http standards easy | Cc: | |
Launchpad Bug: |
Description (last modified by zooko)
I chose a file to upload, left the radiobutton set to Immutable, and clicked the "Upload" button. Konqueror then prompted me to save a file or open the file with a helper app. I chose to save the file. The contents of the resulting saved file were:
upload requires a name
There was no trailing newline.
This is with Konqueror 4.8.3.
Grepping the Tahoe source shows that this line is producing that error message.
Change History (7)
comment:1 Changed at 2012-09-17T15:54:23Z by zooko
comment:2 Changed at 2012-09-17T16:26:24Z by davidsarah
Konqueror is quite unhelpful in the way it decides whether to download or view. I think it will download anything that is not HTML :-( This may mean we need to wrap any text error messages as HTML to fix this (if the Accept header of the request includes text/html, which it will for Konqueror).
comment:3 Changed at 2012-09-17T16:27:02Z by davidsarah
- Keywords html http standards added
- Milestone changed from undecided to eventually
comment:4 Changed at 2012-09-17T16:33:16Z by davidsarah
- Keywords easy added
- Milestone changed from eventually to soon
It looks as though raised exceptions (such as WebError in this case) get converted into an HTTP response body in only one place: MyExceptionHandler at src/allmydata/web/common.py@5324#L287. That makes things easier.
comment:5 Changed at 2012-09-17T16:41:35Z by davidsarah
- Owner set to zooko
Hmm, can you test whether this works for Konqueror (at line 293 of web/common.py):
req.setHeader("content-disposition", "inline")
comment:6 Changed at 2012-09-17T22:26:55Z by zooko
- Status changed from new to assigned
comment:7 Changed at 2014-12-11T22:29:11Z by zooko
- Description modified (diff)
- Resolution set to wontfix
- Status changed from assigned to closed
See #1809 for the separate issue that the name should have been provided.