automatically url-decode capabilities in cli

[ChosenOne]

currently copy&paste from WUI to CLI messes things up, when capstrings come into play: my browser shows colons as %3A and I don't like replacing them every time.

How about the CLI automatically URL-decoding capstrings when required? I suppose that this might pose a few risk, so afaict a simple string capstr.replace("%3A",':') might suffice? Are there other special chars we'd need to take care of?

[zooko]

Hm, uri.py already has a regex that accepts either : or %3A in those spots. Maybe we just need to make sure that the CLI passes the strings to uri.py instead of trying to parse the strings itself? What is the error that occurs when you paste a cap with "%3A" in it to the CLI?

[ChosenOne]

Sorry, this is 1.9.0. Maybe it's already included in 1.9.2?

Here's the output

$ tahoe add-alias delme URI%3ADIR2%3Amchangethisay4wy7i%3Aocblablablawrongcapstringblablaq
Traceback (most recent call last):
  File "/home/freddy/opt/tahoe-lafs/src/allmydata/scripts/runner.py", line 117, in run
    rc = runner(sys.argv[1:], install_node_control=install_node_control)
  File "/home/freddy/opt/tahoe-lafs/src/allmydata/scripts/runner.py", line 102, in runner
    rc = cli.dispatch[command](so)
  File "/home/freddy/opt/tahoe-lafs/src/allmydata/scripts/cli.py", line 507, in add_alias
    rc = tahoe_add_alias.add_alias(options)
  File "/home/freddy/opt/tahoe-lafs/src/allmydata/scripts/tahoe_add_alias.py", line 48, in add_alias
    cap = uri.from_string_dirnode(cap).to_string()
  File "/home/freddy/opt/tahoe-lafs/src/allmydata/uri.py", line 949, in from_string_dirnode
    assert IDirnodeURI.providedBy(u)
AssertionError

[davidsarah]

Duplicate of #942. I'll add a note to that ticket to say it applies to both the CLI and WUI (the latter doesn't accept URL-escaping in form fields).

[davidsarah]

Replying to zooko:

Hm, uri.py already has a regex that accepts either : or %3A in those spots. Maybe we just need to make sure that the CLI passes the strings to uri.py instead of trying to parse the strings itself? What is the error that occurs when you paste a cap with "%3A" in it to the CLI?

SEP, which contains the "%3A", is only used in the HUMAN_RE regex for each URI class, not for the STRING_RE regex. As far as I know the HUMAN_RE regexes are never used (I thought there was a cleanup ticket about that, but I can't find it if there is).

[davidsarah]

Replying to davidsarah:

As far as I know the HUMAN_RE regexes are never used (I thought there was a cleanup ticket about that, but I can't find it if there is).

Filed as #1807.

[jg71]

+1