iputil cannot get local IP addresses on newer Dragonfly BSD (sys.platform == "dragonfly2")

[phma]

Here is the log:

2012-04-04 20:35:05-0400 [-] Log opened.
2012-04-04 20:35:05-0400 [-] twistd 10.1.0 (/usr/pkg/bin/python2.6 2.6.7) starting up.
2012-04-04 20:35:05-0400 [-] reactor class: twisted.internet.selectreactor.SelectReactor.
2012-04-04 20:35:05-0400 [-] foolscap.pb.Listener starting on 14159
2012-04-04 20:35:05-0400 [-] nevow.appserver.NevowSite starting on 3456
2012-04-04 20:35:05-0400 [-] Starting factory <nevow.appserver.NevowSite instance at 0x2aade40c>
2012-04-04 20:35:05-0400 [-] My pid: 20180
2012-04-04 20:35:05-0400 [-] twisted.internet.protocol.DatagramProtocol starting on 1889
2012-04-04 20:35:05-0400 [-] Starting protocol <twisted.internet.protocol.DatagramProtocol instance at 0x2aade98c>
2012-04-04 20:35:05-0400 [-] (Port 1889 Closed)
2012-04-04 20:35:05-0400 [-] Stopping protocol <twisted.internet.protocol.DatagramProtocol instance at 0x2aade98c>
2012-04-04 20:35:05-0400 [-] Unhandled Error
	Traceback (most recent call last):
	  File "/usr/pkg/lib/python2.6/threading.py", line 504, in __bootstrap
	    self.__bootstrap_inner()
	  File "/usr/pkg/lib/python2.6/threading.py", line 532, in __bootstrap_inner
	    self.run()
	  File "/usr/pkg/lib/python2.6/threading.py", line 484, in run
	    self.__target(*self.__args, **self.__kwargs)
	--- <exception caught here> ---
	  File "/usr/pkg/lib/python2.6/site-packages/twisted/python/threadpool.py", line 207, in _worker
	    result = context.call(ctx, function, *args, **kwargs)
	  File "/usr/pkg/lib/python2.6/site-packages/twisted/python/context.py", line 59, in callWithContext
	    return self.currentContext().callWithContext(ctx, func, *args, **kw)
	  File "/usr/pkg/lib/python2.6/site-packages/twisted/python/context.py", line 37, in callWithContext
	    return func(*args,**kw)
	  File "/usr/pkg/lib/python2.6/site-packages/allmydata/util/iputil.py", line 213, in _synchronously_find_addresses_via_config
	    raise UnsupportedPlatformError(sys.platform)
	allmydata.util.iputil.UnsupportedPlatformError: dragonfly2
	
2012-04-04 20:35:05-0400 [-] Node._startService failed, aborting
2012-04-04 20:35:05-0400 [-] [Failure instance: Traceback: <class 'allmydata.util.iputil.UnsupportedPlatformError'>: dragonfly2
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/threading.py:504:__bootstrap
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/threading.py:532:__bootstrap_inner
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/threading.py:484:run
2012-04-04 20:35:05-0400 [-] --- <exception caught here> ---
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/site-packages/twisted/python/threadpool.py:207:_worker
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/site-packages/twisted/python/context.py:59:callWithContext
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/site-packages/twisted/python/context.py:37:callWithContext
2012-04-04 20:35:05-0400 [-] /usr/pkg/lib/python2.6/site-packages/allmydata/util/iputil.py:213:_synchronously_find_addresses_via_config
2012-04-04 20:35:05-0400 [-] ]
2012-04-04 20:35:05-0400 [-] calling os.abort()
2012-04-04 20:35:05-0400 [-] calling os.abort()

Here's the client section of tahoe.cfg:

# Which services should this client connect to?
introducer.furl = pb://tin57bdenwkigkujmh6rwgztcoh7ya7t@pubgrid.tahoe-lafs.org:50528/introducer
helper.furl =
#key_generator.furl =
stats_gatherer.furl = pb://cmmth6b3lsj2orir3u5yqwwae7xfmxxq@pubgrid.tahoe-lafs.org:51424/jdoyd3kke4zqkmmvlhveb57xsw623kh5

[davidsarah]

iputil is too pessimistic about whether common Unixish commands to get IP addresses will work on some random Unix. There are several command variants, but not many. It should just try all the possibilities in some sensible order, rather than trying to detect the exact platform.

[zooko]

See #1988

[phma]

I added this line to _platform_map in iputil.py and it works:

"dragonfly3": "bsd",

The problem with this is that, when DragonFly 4 comes out, it will break. The OS recognition should be done by prefix substring matching instead. Any OS name that begins with "openbsd" or "netbsd" or "freebsd" or "dragonfly" is a BSD, regardless of the version number.

[zooko]

Here's a list of all tickets about "iputil":

https://tahoe-lafs.org/trac/tahoe-lafs/query?status=!closed&keywords=~iputil

Hm, we need to open a new ticket for Daira's suggestion from #1918, to try invoking ifconfig (and then maybe route.exe?) regardless of platform.

[Daira Hopwood <david-sarah@…>]

In a493ee0bb641175ecf918e28fce4d25df15994b6/trunk:

iputil.py: add tests for recent changes. refs #1381, #1988, #982, #1064, #1536, #1935, #898, #1707, #1918

Signed-off-by: Daira Hopwood <david-sarah@…>

[daira]

iputil on trunk no longer distinguishes between Unix variants, which fixes this bug.