Opened at 2011-10-16T17:44:56Z

Closed at 2011-10-17T00:06:29Z

Last modified at 2012-11-24T19:46:42Z

#1564 closed defect (duplicate)

DeprecationWarning in sftpd.py against Twisted >11.0

Reported by: warner Owned by: davidsarah
Priority: minor Milestone: 1.10.0
Component: code-frontend Version: 1.9.0b1
Keywords: sftp deprecation twisted Cc:
Launchpad Bug:

Description

I ran the tahoe test suite against current Twisted trunk, to see what happens. I got one test failure (addressed elsewhere) and one deprecation: 

334:warner@Cookies% PYTHONPATH=~/stuff/python/twisted/trunk make quicktest
python bin/tahoe debug trial  allmydata
/Users/warner2/stuff/tahoe/trunk-foolscap/src/allmydata/frontends/sftpd.py:25: DeprecationWarning: twisted.internet.interfaces.IFinishableConsumer was deprecated in Twisted 11.1.0: Please use IConsumer (and IConsumer.unregisterProducer) instead.
  from twisted.internet.interfaces import IFinishableConsumer

Is it possible to change sftpd.py to follow their advice and still remain compatible with our current spec of Twisted >= 10.1.0 ?

Change History (6)

comment:1 Changed at 2011-10-16T17:46:52Z by warner

  • Milestone changed from undecided to 1.10.0

I suspect the fix for this will be too risky for 1.9, but I'd like to have it in early in the next cycle.

comment:2 Changed at 2011-10-16T20:47:48Z by davidsarah

  • Cc davidsarah removed
  • Component changed from code to code-frontend
  • Keywords sftp deprecation twisted added
  • Owner changed from somebody to davidsarah
  • Status changed from new to assigned

The fix for #1525 removes the use of IFinishableConsumer. It wasn't (and isn't) ready for 1.9, because I had difficulty getting the test on that ticket to work.

comment:3 Changed at 2011-10-16T20:49:02Z by davidsarah

There should be no problem retaining compatibility with Twisted 10.1, though.

comment:4 Changed at 2011-10-17T00:06:29Z by warner

  • Resolution set to duplicate
  • Status changed from assigned to closed

ok, this ticket is unneeded then. thanks!

comment:5 Changed at 2012-04-01T00:02:07Z by davidsarah

  • Milestone changed from 1.11.0 to 1.10.0

comment:6 Changed at 2012-11-24T19:46:42Z by davidsarah

This is actually a duplicate of #1295.

Note: See TracTickets for help on using tickets.