#1519 closed defect (fixed)

trac: revision log doesn't always see commits

Reported by: davidsarah Owned by: somebody
Priority: major Milestone: soon (release n/a)
Component: dev-infrastructure Version: 1.9.0a1
Keywords: trac darcs Cc: zooko
Launchpad Bug:

Description (last modified by daira)

I committed a patch to docs/write_coordination.rst, with description "docs/write_coordination.rst: fix formatting and add more specific warning about access via sshfs." The revision immediately before this commit was r5236. The trac source browser shows the effect of the patch on the file, but it does not show the commit, either in the revision log (global or per-file) or in the annotated rendering of the file.

I suspect that the trac notification posthook sometimes fails, although there is no indication that it did in the darcs push output:

[...]
Thu Sep  1 00:21:48 BST 2011  david-sarah@jacaranda.org
  * docs/write_coordination.rst: fix formatting and add more specific warning about access via sshfs.
Shall I push this patch? (10/10)  [ynWsfvplxdaqjk], or ? for help: y
Enter passphrase for key '/home/davidsarah/.ssh/id_rsa': 
Note: if you want to change the default remote repository to
source@tahoe-lafs.org:darcs/tahoe-lafs/trunk,
quit now and issue the same command with the --set-default flag.
now in tahoe-lafs.orgs generic-posthook.sh
about to sh notify-trac.sh
Finished applying...
Posthook ran successfully.
Finished applying...
Posthook ran successfully.
sending 1 change to buildmaster:
 20110831232148-93fa1-7405c0ec191575e135f61093ee2fe45dc45b4ce5.gz
change sent successfully
Push successful.

Change History (4)

comment:1 Changed at 2011-09-01T00:52:39Z by davidsarah

This might be either a clue or a red herring: the "default remote repository" prompt says "source@tahoe-lafs.org:darcs/tahoe-lafs/trunk", but that is not the repo I was pushing to:

davidsarah@shinier:~/tahoe/1.9alpha$ darcs push
Enter passphrase for key '/home/davidsarah/.ssh/id_rsa': 
Pushing to "davidsarah@dev.allmydata.org:/home/darcs/tahoe/trunk"...

Edit: oh, but that output might be from the invocation of darcs on dev.allmydata.org pushing to tahoe-lafs.org, not the local darcs. So probably a red herring.

Last edited at 2011-09-01T00:54:36Z by davidsarah (previous) (diff)

comment:2 Changed at 2011-09-01T21:21:53Z by zooko

  • Cc zooko added

comment:3 follow-up: Changed at 2012-03-26T17:08:56Z by zooko

This will probably be fixed by our move to git -- #1644.

comment:4 in reply to: ↑ 3 Changed at 2013-06-15T12:51:13Z by daira

  • Description modified (diff)
  • Milestone changed from undecided to soon (release n/a)
  • Resolution set to fixed
  • Status changed from new to closed

Replying to zooko:

This will probably be fixed by our move to git -- #1644.

I think it was.

Note: See TracTickets for help on using tickets.