#1458 closed defect (fixed)
drop-upload: on startup, scan for files created or changed while the gateway was not running
| Reported by: | davidsarah | Owned by: | daira |
|---|---|---|---|
| Priority: | major | Milestone: | 1.12.0 |
| Component: | code-frontend-magic-folder | Version: | 1.8.2 |
| Keywords: | drop-upload otf-magic-folder-objective2 | Cc: | |
| Launchpad Bug: |
Description (last modified by davidsarah)
... or use Change Journals on Windows or FSEvents on Mac OS X.
Change History (16)
comment:1 Changed at 2011-08-19T05:28:59Z by davidsarah
- Description modified (diff)
comment:2 Changed at 2011-12-12T04:34:15Z by davidsarah
- Milestone changed from undecided to soon
- Owner set to davidsarah
- Status changed from new to assigned
comment:3 Changed at 2014-12-02T19:47:35Z by warner
- Component changed from code-frontend to code-frontend-drop-upload
comment:4 Changed at 2015-03-12T23:54:13Z by daira
- Keywords otf-magic-folder added
comment:5 Changed at 2015-03-17T22:15:17Z by daira
- Owner changed from davidsarah to daira
- Status changed from assigned to new
comment:6 Changed at 2015-03-17T22:18:05Z by daira
- Status changed from new to assigned
comment:7 Changed at 2015-04-02T14:55:47Z by daira
- Keywords otf-magic-folder-objective2 added; otf-magic-folder removed
comment:8 Changed at 2015-04-11T03:25:50Z by dawuud
comment:9 Changed at 2015-04-12T22:35:23Z by daira
- Milestone changed from soon to 1.11.0
comment:10 Changed at 2015-04-14T04:40:54Z by dawuud
i added more code to my dropupload-scan-on-startup-1458-1 branch. when the service is start the basedir is scanned and it uses the database to identify files that haven't yet been uploaded.
in this code branch we do not yet have an upload dequeue so i've been using a stub method to represent adding a file to the upload dequeue.
also i added some unit tests. a simple test for the db creation. and a test for startup/shutdown of the drop uploader service.
comment:11 Changed at 2015-04-17T00:58:58Z by dawuud
refactored the unit tests... and fixed the mock errors unit tests. same branch. all tests passing now.
comment:12 Changed at 2015-04-23T00:39:07Z by dawuud
I created better tests for this... and writing them assisted in helping me find a severe bug in the uploader... which I fixed. Now the uploader does in fact properly persist upload file entries; I have unit tests to prove it! All this and more is available in my latest branch here:
https://github.com/david415/tahoe-lafs/tree/2406.otf-objective-2.3.1-fix-upload-deque
Daira, can you please help me get rid of the time.sleep from the _test_persistence unit test?
comment:13 Changed at 2015-04-24T17:47:00Z by daira
Reviewing.
comment:14 Changed at 2015-05-02T16:42:53Z by daira
- Resolution set to fixed
- Status changed from assigned to closed
comment:15 Changed at 2015-05-02T16:44:18Z by daira
Closing this and using ticket #2406 for any further review comments.
comment:16 Changed at 2016-03-22T05:02:52Z by warner
- Milestone changed from 1.11.0 to 1.12.0
Milestone renamed
amiller mentioned this as one of his most-wanted improvements to drop-upload.