Opened at 2011-07-22T00:17:20Z
Closed at 2011-07-22T05:26:54Z
#1438 closed defect (fixed)
update the dependency on Twisted to >= 10.1
Reported by: | davidsarah | Owned by: | zooko |
---|---|---|---|
Priority: | major | Milestone: | 1.9.0 |
Component: | packaging | Version: | 1.8.2 |
Keywords: | reviewed | Cc: | |
Launchpad Bug: |
Description
There are three reasons to update the Twisted requirement to >= 10.1:
- it would fix our indirect dependency on pywin32 on Windows when using Twisted < 9.0 (#1274)
- it would ensure that the twisted.internet.inotify package is available for use by the drop-upload feature on Linux (#1429)
- it would make the FTP server work without users potentially having to patch Twisted (see http://twistedmatrix.com/trac/ticket/3462 and docs/frontends/FTP-and-SFTP.rst@5036#dependencies).
I'm splitting this into its own ticket so that it can be reviewed and discussed separately (I'd previously bundled the update into the patch to fix #1435).
Attachments (2)
Change History (5)
Changed at 2011-07-22T00:37:24Z by davidsarah
Changed at 2011-07-22T01:23:50Z by davidsarah
This includes the previous patch but also removes the check in ftpd.py that Twisted supports async close, since that check is no longer needed. (Opinions wanted on whether it is desirable to remove this check.)
comment:1 Changed at 2011-07-22T05:21:50Z by zooko
- Keywords reviewed added
- Owner changed from davidsarah to zooko
I reviewed attachment:update-twisted-dependency-2.darcs.patch and it is good.
comment:2 Changed at 2011-07-22T05:22:16Z by zooko
Oh, and yes I think we should remove the specific check.
comment:3 Changed at 2011-07-22T05:26:54Z by david-sarah@…
- Resolution set to fixed
- Status changed from new to closed
In 8b4082677477daf1:
Update the dependency on Twisted to >= 10.1. This allows us to simplify some documentation: it's no longer necessary to install pywin32 on Windows, or apply a patch to Twisted in order to use the FTP frontend. fixes #1274, #1438. refs #1429