Opened at 2007-08-23T22:22:50Z
Closed at 2013-06-15T12:49:39Z
#122 closed defect (invalid)
does github webhook report tags? do they trigger the buildbot?
Reported by: | warner | Owned by: | warner |
---|---|---|---|
Priority: | minor | Milestone: | eventually |
Component: | dev-infrastructure | Version: | 0.5.0 |
Keywords: | buildbot darcs release | Cc: | |
Launchpad Bug: |
Description (last modified by daira)
The darcs_buildbot.py post-commit hook doesn't send a Change object to the buildmaster when a tag is pushed into the repository. As a result, the buildbot doesn't automatically build .debs of released versions, only of intermediate versions. This is a pity, because it would be nice for us to have packages of official releases.
I'm not sure what is necessary to fix this: I seem to recall that tags in darcs are handled very differently than regular patches, so the 'apply' action might not be enough to catch both. On the other hand, it might just be that the darcs_buildbot.py script (which is run by the apply action) is deficient, perhaps exiting if it sees no files changed when it should send a Change anyway.
Change History (5)
comment:1 Changed at 2009-12-13T06:01:25Z by davidsarah
- Keywords darcs added
comment:2 Changed at 2010-04-13T00:09:05Z by davidsarah
- Keywords release added
comment:3 follow-up: ↓ 4 Changed at 2013-03-20T19:35:40Z by warner
- Summary changed from darcs+buildbot postcommit hook doesn't report tags to does github webhook report tags? do they trigger the buildbot?
Now that we're on git, we should test to see if pushing just a git tag to github triggers the same sort of change message (I suspect it will). I don't know, however, if the buildbot will react to a tag message by triggering a build (I suspect it won't). This would be nice to have, so we don't have to push changes and tags at the same time.
comment:4 in reply to: ↑ 3 Changed at 2013-03-20T21:54:23Z by davidsarah
Replying to warner:
[...] I don't know, however, if the buildbot will react to a tag message by triggering a build (I suspect it won't). This would be nice to have, so we don't have to push changes and tags at the same time.
If this does work, remember to change git/docs/how_to_make_a_tahoe-lafs_release.org to take account of that.
comment:5 Changed at 2013-06-15T12:49:39Z by daira
- Description modified (diff)
- Resolution set to invalid
- Status changed from new to closed
We are no longer using darcs. Also, we've delegated responsibility for building .debs to the Debian and Ubuntu package maintainers.
The workaround for this is to push a minor change and a tag at the same time. This isn't really very satisfactory, since it makes the release process more error-prone.