Opened at 2010-08-12T20:39:56Z
Last modified at 2012-12-20T16:32:10Z
#1171 reopened defect
add regression test for shnums: "e,r,r,o,r"
| Reported by: | zooko | Owned by: | warner |
|---|---|---|---|
| Priority: | normal | Milestone: | soon |
| Component: | code-frontend-web | Version: | 1.8β |
| Keywords: | download immutable test-needed | Cc: | |
| Launchpad Bug: |
Description
In this download status page that I attached to #1170 -- http://tahoe-lafs.org/trac/tahoe-lafs/attachment/ticket/1170/down-1.html one of the entries in the "shnums" column (the one for serverid 62nlabgf), says e,r,r,o,r.
Change History (13)
comment:1 Changed at 2010-08-12T20:43:02Z by zooko
- Keywords unfinished-business added
comment:2 Changed at 2010-08-14T07:05:15Z by zooko
- Milestone changed from undecided to 1.8.0
comment:3 Changed at 2010-08-14T18:36:22Z by warner
I agree with checking that it doesn't cause worse problems, but I have a for-after-1.8.0 patch to rewrite the way that errors are recorded in the DownloadStatus structure that will make this go away.
comment:4 Changed at 2010-08-21T21:56:32Z by davidsarah
- Milestone changed from 1.8.0 to 1.9.0
comment:5 Changed at 2010-10-22T13:41:23Z by zooko
- Milestone changed from 1.9.0 to 1.8.1
This is another bug that was introduced in v1.8.0 and it would be great if we could fix it in v1.8.1, but someone would have to volunteer to do the work quite soon.
comment:6 Changed at 2010-11-02T02:26:35Z by zooko
- Milestone changed from 1.8.1 to soon
comment:7 Changed at 2012-06-29T13:06:43Z by davidsarah
- Milestone changed from soon to 1.10.0
- Owner set to warner
warner: can your patch mentioned in comment:3 be applied for 1.10 without disruption?
comment:8 Changed at 2012-09-04T16:41:28Z by warner
I'll investigate.. this one might alredy be fixed now.
comment:9 Changed at 2012-09-04T23:59:40Z by warner
- Resolution set to fixed
- Status changed from new to closed
It looks like the changes I had in mind have been applied already. Specifically, source:src/allmydata/immutable/downloader/status.py#L42 DYHBEvent has a distinct error() method, and source:src/allmydata/immutable/downloader/finder.py calls exactly one of finished() or error(). So shnums should only ever be a list of share numbers (keys of the dict-of-buckets returned by a successful DYHB call).
So I'm closing this one.
comment:10 Changed at 2012-09-05T02:14:27Z by zooko
I briefly looked at the two links into the source code that Brian posted in comment:9 and it looks good to me.
comment:11 Changed at 2012-09-05T03:31:57Z by davidsarah
- Keywords test-needed added; unfinished-business removed
- Resolution fixed deleted
- Status changed from closed to reopened
- Summary changed from shnums: "e,r,r,o,r" to add regression test for shnums: "e,r,r,o,r"
This didn't have a test though. Ideally we should have a regression test.
comment:12 Changed at 2012-12-13T17:10:43Z by davidsarah
- Priority changed from major to normal
comment:13 Changed at 2012-12-20T16:32:10Z by davidsarah
- Milestone changed from 1.10.0 to 1.11.0
Perhaps we should investigate and make sure that this doesn't cause worse problems, and fix it in 1.8.0 if it is easy to fix or if it causes worse problems.