Opened at 2010-05-11T01:06:54Z
Last modified at 2010-06-08T04:34:53Z
#1034 closed defect
MetadataSetter does not enforce restriction on setting "tahoe" subkeys — at Initial Version
| Reported by: | davidsarah | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.7.0 |
| Component: | code-dirnodes | Version: | 1.6.1 |
| Keywords: | cleanup reviewed | Cc: | |
| Launchpad Bug: |
Description
When the metadata of a child in a directory is updated, the "tahoe" subkeys are not supposed to be changed. (This is not a security restriction, since someone with a writecap to the directory could bypass it; it's just desired behaviour for normal usage.)
This behaviour is enforced by Adder in source:src/allmydata/dirnode.py .
However, it is not enforced by MetadataSetter in the same file. Currently, MetadataSetter is only used by the set_metadata_for method of dirnodes, which is not accessible via the webapi. (The webapi set-children operation uses Adder.)
Either set_metadata_for should be considered for removal since it is not accessible, or it should have the same behaviour as Adder for "tahoe" subkeys.
