*.xhtml and tahoe.css are not copied from web directory on Windows

[freestorm]

When Tahoe is installed using setup.py install from a darcs checkout, the *.xhtml and tahoe.css from web directory are not copied to lib/allmydata/web.

The result is that the web interface cannot be used, because of the missing files.

This issue occurs only on Windows.

It works in these cases (Windows):

• Installing tahoe from tarballs
• Creating tarballs with "python setup.py sdist"
• Running bin/tahoe from the source directory

Tested with python2.6

External link: ​http://mail.python.org/pipermail/distutils-sig/2006-October/006740.html

[zooko]

Let's add a test of this behavior. Let's see, if everything is working then we should get a string containg 'html xmlns' from calling getxmlfile()​ with argument 'directory.xhtml'.

[zooko]

Test added in 6037df55b372beb6. In addition I've attempted to program the buildbots so that a few of them, including FreeStorm's, run the unit tests from installed locations, but I doubt that I succeeded at that.

[freestorm]

I wrote the patch for run_trial.py,

I copied into build/misc/run_trial.py on my buildbot.

And after run:

python -c "import glob,os,subprocess,sys;os.chdir('egginstalldir');os.environPATH?=os.getcwd()+os.pathsep+os.environPATH?;os.environPYTHONPATH?=os.pathsep.join(glob.glob('*.egg'))+os.pathsep+os.environ.get('PYTHONPATH',);sys.exit(subprocess.call(['python','../misc/run_trial.py', 'allmydata.test'], env=os.environ))"

and it work :-)

Maybe, we can do: os.chdir('../'); before calling subprocess and simply calling 'python','misc/run_trial.py'

Fred

[zooko]

Okay we have automated tests of this issue now.

Here is a build step that is producing the .egg on Kyle's OpenBSD and it succeeds:

​http://tahoe-lafs.org/buildbot/builders/Kyle%20OpenBSD-4.6%20amd64/builds/146/steps/create-egg/logs/stdio

You can see that it is including the xhtml files in the .egg.

Here is the same step on FreeStorm?'s WinXP which doesn't mention any xhtml files:

​http://tahoe-lafs.org/buildbot/builders/FreeStorm%20WinXP-x86%20py2.6/builds/14/steps/create-egg/logs/stdio

Then here is the step which runs the unit tests from the installed location after installing from the egg that it built. The tests pass on Kyle's OpenBSD:

​http://tahoe-lafs.org/buildbot/builders/Kyle%20OpenBSD-4.6%20amd64/builds/146/steps/test-from-egg/logs/stdio

and fail on FreeStorm?'s WinXP:

​http://tahoe-lafs.org/buildbot/builders/FreeStorm%20WinXP-x86%20py2.6/builds/14/steps/test-from-egg/logs/stdio

(We also have comparable tests of installing and running from the installed version that doesn't use .egg format, that also passes on Kyle's and fails on FreeStorm?'s.)

Here are the "versions of tools" steps that say what versions of everything are installed on the respective buildslaves:

​http://tahoe-lafs.org/buildbot/builders/Kyle%20OpenBSD-4.6%20amd64/builds/146/steps/show-tool-versions/logs/stdio

​http://tahoe-lafs.org/buildbot/builders/FreeStorm%20WinXP-x86%20py2.6/builds/14/steps/show-tool-versions/logs/stdio

Okay now we can tell if we fix this issue! I would like to fix it by figuring out why the include_package_data=True and the setuptools_darcs features that works on most systems doesn't work on WinXP rather than by applying the patch to manually specify package data.

Oh, I'll bet there is a bug in setuptools_darcs having to do with Windows vs. Unix path separators...

[freestorm]

I've attached the patch for setuptools_darcs/setuptools_darcs.py.
=> path_reparator_change_for_windows.darcs.txt

This patch changes the path separator of "darcs show manifest" output to be correctly processed by setuptools on Windows.

Fred

[zooko]

Okay this is fixed by setuptools_darcs-1.2.9.