Changes between Version 19 and Version 20 of PatchReviewProcess

Timestamp:

2013-01-03T16:46:40Z (12 years ago)

Author:

zooko

Comment:

updated instructions for review

PatchReviewProcess

@@ -24 +24 @@
  3. Read tickets until you find one that you can review.
  4. (optional) Expand "modify ticket" and click "accept", then submit changes.  This marks you as the person reviewing this patch.  If you don't want to commit to this then you can skip this step.
- 5. Read the patch until you understand the docs, tests, code and comments in it.  You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.
+ 5. Read the patch until you understand the docs, tests, code and comments in it.  (You can use the "Browse source" button at the top of the page to read the current versions of the files that the patch changes.)  Post comments on the trac ticket as you go.  If there's something good or bad in the patch you're reviewing, then you'll know it when you see it.
   a. If you can't understand the patch after spending some time on it, then say so in a comment on the ticket!  This might mean that we need to add documentation or comments or to refactor the code.  On the other hand, it might just be that you don't have enough context to understand the code.  That's okay too, so go ahead and speak up.
   b. Check whether every feature or bugfix in the patch has an accompanying test in the patch.
@@ -42 +42 @@
 
 == Ticket attachment links ==
+
+NOTE: we've moved from darcs to git, and we've started using github for some things and continuing to use trac for others. So the following is partially obsolete and needs to be rewritten.
 
 Attachments in a ticket have two links, a name, which points to an html page with prettification, and a raw download link.  You can save the download link (such as by {{{wget}}}) and use {{{darcs apply}}} to configure your repository to test a particular patch. Note that you do not ''have'' to apply a patch to your local repository or test it in order to review it—often just reading the prettified version on the web is sufficient.