Changes between Version 13 and Version 14 of PatchReviewProcess


Ignore:
Timestamp:
2011-04-03T00:36:14Z (14 years ago)
Author:
zooko
Comment:

tweak how-to-review

Legend:

Unmodified
Added
Removed
Modified
  • PatchReviewProcess

    v13 v14  
    33= Why review patches =
    44
    5 We want more patches to be contributed to Tahoe-LAFS.  Getting 
    6 feedback on patches encourages contributors.  Patches languishing in 
    7 the "waiting to be reviewed" state discourages them.  (By the way, 
    8 something else that encourages them is users saying "Thank you.".)
     5We want more patches to be contributed to Tahoe-LAFS.  Patches
     6languishing in the "waiting to be reviewed" state discourages
     7contributors. Getting feedback on patches encourages them.
     8(By the way, something else that encourages them is users saying
     9"Thank you.".)
    910
    1011= Who can review patches =
     
    3536
    3637Once you decide that you like reviewing tickets and you get into the habit of doing it frequently, then read this essay by Jonathan Lange on how to do it well: [http://mumak.net/stuff/your-code-sucks.html Your Code Sucks and I Hate You: The Social Dynamics of Code Reviews].
     38
     39Two simple suggestions:
     401. Say something nice about the author or their code.
     412. You don't have to be extra picky.