Changes between Initial Version and Version 1 of Ticket #4128, comment 3


Ignore:
Timestamp:
2024-11-20T20:42:37Z (6 weeks ago)
Author:
hacklschorsch
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4128, comment 3

    initial v1  
    1 Turns out because our [https://github.com/LeastAuthority/subunitreporter/blob/caa418dcfb545ca4807346ce42996077ef4df592/src/subunitreporter/__init__.py#L100-L106 faulty subunitreporter makes the test suite pass no matter what] this is only bad optics.
     1Turns out because our [https://github.com/LeastAuthority/subunitreporter/blob/caa418dcfb545ca4807346ce42996077ef4df592/src/subunitreporter/__init__.py#L100-L106 faulty subunitreporter makes the test suite pass no matter what] this is only optics:
     2
     3Twisted.trial succeeds (`congratulations :)`), but then subunit2junitxml exits non-zero if it finds failed tests in the report and we are good again.