Opened at 2021-08-16T18:51:56Z

Last modified at 2021-08-19T19:03:04Z

#3763 closed task

Potential issues with `PUT /v1/lease/:storage_index` in GBS protocol — at Version 3

Reported by: itamarst Owned by: exarkun
Priority: normal Milestone: HTTP Storage Protocol
Component: unknown Version: n/a
Keywords: Cc:
Launchpad Bug:

Description (last modified by exarkun)

  1. It says "If there are no shares for the given storage_index then do nothing and return NO CONTENT." 204 is a success code... this seems like maybe more like an error, and should therefore have 4xx code?
  2. What should be returned if there are shares? Anything need to be in the response body? Just 200?
  3. "If the renew-secret value matches an existing lease then that lease will be renewed instead." Why is this, given there exists a separate renew API endpoint? This seems like it could mask certain categories of client bugs.

Change History (3)

comment:1 Changed at 2021-08-16T18:55:58Z by itamarst

Possibly "410 Gone" makes more sense than "204 No content"? Or maybe I'm misunderstanding the order of operations.

comment:2 Changed at 2021-08-16T20:30:37Z by itamarst

Another question: Why does this endpoint exist at all?

Creating an immutable storage index also creates a lease, per the docs: "A lease is also created for the shares." So maybe this endpoint doesn't need to exist at all?

comment:3 Changed at 2021-08-17T10:48:48Z by exarkun

  • Description modified (diff)
Note: See TracTickets for help on using tickets.