| 1 | | To go the manual audit route, given a whole bunch of arbitrary fakes: |
| 2 | | |
| 3 | | 1. For each method in IStorageServer and related objects (bucket reader/writer), grep for method definitions; eventually this should discover all fakes. E.g. allmydata.test.mutable.util.FakeStorageServer is not annotated with the IStorageServer interface but implements it. |
| 4 | | 2. For each fake, temporarily add logic to print tracebacks(?) to file. |
| 5 | | 3. Temporarily add logic to print tracebacks to file for real code too. |
| 6 | | 4. Run unit and integration tests. |
| 7 | | 5. Uniquify file. |
| 8 | | 6. Permanently add interface implementation annotation, so in the future we can just use grep. |
| 9 | | |
| 10 | | At this point we should have locations of all calls into Foolscap storage protocol, and can audit it for bad assumptions like "order of calls matches order of delivery". |
| | 1 | (Moved to #3779). |
