Changes between Version 6 and Version 7 of Ticket #2777


Ignore:
Timestamp:
2020-01-13T20:04:24Z (5 years ago)
Author:
exarkun
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2777 – Description

    v6 v7  
    11I'd like to clean up our unit tests.. there are a lot of archaic idioms that have crept in (partly because I'm not up-to-date on modern practices, partly because the tests were initially written before those practices were established). Here are some things that come to mind:
    22
     3* remove the use of `mock` in favor of proper test doubles
    34* switch from trial's TestCase to testtools' TestCase (probably via a base class in one of our common modules)
    45* replace JUnit-style assertions (`assertEqual(...)`) with "hamcrest" style assertions (`assertThat(x, Equals(y))`)