Changes between Version 7 and Version 12 of Ticket #2777


Ignore:
Timestamp:
2020-11-24T18:23:14Z (4 years ago)
Author:
exarkun
Comment:

Splitting the mock part of this off into ​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/3519

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2777 – Description

    v7 v12  
    11I'd like to clean up our unit tests.. there are a lot of archaic idioms that have crept in (partly because I'm not up-to-date on modern practices, partly because the tests were initially written before those practices were established). Here are some things that come to mind:
    22
    3 * remove the use of `mock` in favor of proper test doubles
     3* [ticket:3519 remove the use of `mock` in favor of proper test doubles]
    44* switch from trial's TestCase to testtools' TestCase (probably via a base class in one of our common modules)
    55* replace JUnit-style assertions (`assertEqual(...)`) with "hamcrest" style assertions (`assertThat(x, Equals(y))`)