Changes between Initial Version and Version 1 of Ticket #2569, comment 11


Ignore:
Timestamp:
2015-12-07T15:48:06Z (9 years ago)
Author:
meejah
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2569, comment 11

    initial v1  
    11Daira reviewed the diff to give a preliminary opinion on new progress interface etc; these are my notes from that (any errors are my fault):
    22
    3  . look in collections for limited-length queue abstraction
    4  . 'deque' is the right abstraction for the down/up-load history
    5  . likes QueueItem refactoring
    6  . just want PercentProgress (and change interface to include set_progress_total())
    7  . @implementer -> implements (and/or when did zope.interface introduce decorator?)
    8  . there's some commented-out-code in downloader that should go to
    9    queue mixin
     3 - look in collections for limited-length queue abstraction
     4 - 'deque' is the right abstraction for the down/up-load history
     5 - likes QueueItem refactoring
     6 - just want PercentProgress (and change interface to include set_progress_total())
     7 - @implementer -> implements (and/or when did zope.interface introduce decorator?)
     8 - there's some commented-out-code in downloader that should go to queue mixin